fix: DDR score validation with judgements using step counts #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A commit has changed the seeds. View the diff here. |
Gyoo
force-pushed
the
stepCounts
branch
2 times, most recently
from
f2737bb
to
19df306
Compare
zkrising
requested changes
Aug 27, 2024
| @@ -164,7 +164,8 @@ export type GPTGoalProgressFormatters<GPT extends GPTString> = { | |||
| * indicating what the error was on failure. | |||
| */ | |||
| export type ScoreValidator<GPT extends GPTString> = ( | |||
| score: ScoreDocument<GPT> | |||
There was a problem hiding this comment.
This is sensible and should be merged regardless of the sheet data issues, although chart need not be optional.
There was a problem hiding this comment.
I'll make a separate PR for that and set this one as draft until I can figure out another solution for stepcounts then
|
What changed between now and the previous state of affairs? You've done a force-push so I can't exactly figure out what was done myself. |
|
Sorry, bad habit from work. |
|
Awesome stuff. Thank you man. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScoreValidator